ClearFoundation Tracker - ClearOS
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000011ClearOSdeprecated - ClearOS 5 Protocol Filterpublic2010-01-18 16:472010-07-15 12:01
ReporterVejlefjordskolen 
Assigned Todsokoloski 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version5.1 
Target Version5.2Fixed in Version5.2 
Summary0000011: Protocol Filter report does not show number of packets or bytes over 100,000
DescriptionIn the API, /var/webconfig/api/Layer7Filter.class.php, you match only digits in the output from iptables where the number of packets and bytes are shown, but when there are more than 100,000 packets or bytes, the number also contains letters, e.g. 100K instead of 100000. This causes your matching to fail, resetting the counters to zero.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filestgz counter-fix.tgz (979) 2010-04-18 15:58
https://tracker.clearos.com/file_download.php?file_id=8&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-01-18 16:47VejlefjordskolenNew Issue
2010-01-19 08:16user2Severityminor => tweak
2010-01-19 08:16user2Statusnew => acknowledged
2010-01-19 08:16user2Target Version => 5.2
2010-03-25 20:29user2Statusacknowledged => assigned
2010-03-25 20:29user2Assigned To => dsokoloski
2010-04-15 16:13dsokoloskiCheckin
2010-04-15 16:13dsokoloskiNote Added: 0000080
2010-04-15 16:13dsokoloskiStatusassigned => resolved
2010-04-15 16:13dsokoloskiResolutionopen => fixed
2010-04-18 15:58VejlefjordskolenNote Added: 0000081
2010-04-18 15:58VejlefjordskolenStatusresolved => feedback
2010-04-18 15:58VejlefjordskolenResolutionfixed => reopened
2010-04-18 15:58VejlefjordskolenFile Added: counter-fix.tgz
2010-04-18 16:03VejlefjordskolenNote Edited: 0000081
2010-04-18 16:09dsokoloskiCheckin
2010-04-18 16:09dsokoloskiNote Added: 0000082
2010-04-18 16:09dsokoloskiStatusfeedback => resolved
2010-04-18 16:09dsokoloskiResolutionreopened => fixed
2010-04-18 16:23dsokoloskiCheckin
2010-04-18 16:23dsokoloskiNote Added: 0000083
2010-05-19 11:30user2Fixed in Version => 5.2
2010-07-15 12:01user2Statusresolved => closed
2018-01-15 16:31user2Categoryapp-protocol-filter - Protocol Filter Manager => app-protocol-filter - ClearOS 5
2018-01-15 16:32user2Categoryapp-protocol-filter - ClearOS 5 => deprecated - ClearOS 5 Protocol Filter

Notes
(0000080)
dsokoloski   
2010-04-15 16:13   
Source Code Changelog
---------------------------------------------------
- Fix for packet/byte counters with M/K/G postfix. [fixed tracker 0000011]

File Changes
---------------------------------------------------
U legacy/webconfig/trunk/api/Layer7Filter.class.php
(0000081)
Vejlefjordskolen   
2010-04-18 15:58   
(edited on: 2010-04-18 16:03)
The fix checked in will not work correctly, as the protocol-filter-report pages do not support strings in the fields for the counters, only numbers.

I have attached my fix as patch sets from the current SVN trunk. (I hope I did it right, I've never made patch sets before). It has an extra case for handling the possibility of no counter, as the JavaScript on the protocol-filter-report page does not support empty strings in the XML.
(0000082)
dsokoloski   
2010-04-18 16:09   
Source Code Changelog
---------------------------------------------------
- Changed layer-7 protocol format string from decimal to string. [fixed tracker 0000011]

File Changes
---------------------------------------------------
U legacy/webconfig/trunk/htdocs/admin/protocol-filter-report.php
(0000083)
dsokoloski   
2010-04-18 16:23   
Source Code Changelog
---------------------------------------------------
- Changed layer-7 protocol format string from decimal to string. [fixed tracker 0000011]

File Changes
---------------------------------------------------
U legacy/webconfig/trunk/htdocs/admin/protocol-filter-report.xml.php